The most common and most likely answer to this crossword clue is the 5 plus 7 letter word MUSIC TEACHER
I've seen this crossword clue in The Daily Telegraph
M
U
S
I
C
T
E
A
C
H
E
R
Buddy explains!
The straight part
We know that "One whose pupils are encouraged to make notes" is the straight/definition part of the clue. The straight part is often a synonym or definition, in this case one whose pupils are encouraged to make notes = music teacher.The cryptic/wordplay part
In cryptic crossword there's often an wordplay/cryptic part as well.This part involves a more complex hint, such as an anagram, homophone, hidden word, etc.
Sadly, We don't have an explanation for this specific crossword clue yet.